Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router should return Content-Type header #636

Closed
damienpontifex opened this issue Mar 14, 2022 · 2 comments · Fixed by #639 or #1154
Closed

Router should return Content-Type header #636

damienpontifex opened this issue Mar 14, 2022 · 2 comments · Fixed by #639 or #1154
Assignees
Labels

Comments

@damienpontifex
Copy link
Contributor

Is your feature request related to a problem? Please describe.
If the response is successful, I would expect the response from the router to have a response header of Content-Type: application/json. Our subgraphs do, but the router doesn't so some tools complain because they look at this header to determine how to parse the response.

Describe the solution you'd like
Router response includes header of Content-Type: application/json

Describe alternatives you've considered
nil

Additional context
Current headers from Postman with response from router
image

@garypen garypen added bug and removed triage labels Mar 15, 2022
@garypen garypen self-assigned this Mar 15, 2022
garypen added a commit that referenced this issue Mar 15, 2022
If we haven't already set a Content-Type header, then make sure that we
set one with a value of "application/json".

fixes: #636
garypen added a commit that referenced this issue Mar 15, 2022
* Router should return Content-Type header

If we haven't already set a Content-Type header, then make sure that we
set one with a value of "application/json".

fixes: #636
@abernix abernix added this to the v0.1.0-alpha.9 milestone Mar 16, 2022
@krisztian-sala
Copy link

Is this still working? With v0.9.0+ the Content-Type header is not returned

@bnjjj bnjjj assigned bnjjj and unassigned garypen May 24, 2022
@bnjjj
Copy link
Contributor

bnjjj commented May 24, 2022

Seems not, I will re open it and fix it :) Thanks

@bnjjj bnjjj reopened this May 24, 2022
@abernix abernix modified the milestones: v0.1.0-alpha.9, v0.9.3 May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants