Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose GraphQLQueryWatcher init method #750

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Expose GraphQLQueryWatcher init method #750

merged 1 commit into from
Sep 4, 2019

Conversation

mikaelbartlett
Copy link

This is a small fix exposing GraphQLQueryWatcher init method.

We would like to have this to be able to mock and test using ApolloClientProtocol.

@apollo-cla
Copy link

@mikaelbartlett: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

designatednerd
designatednerd approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah good catch - ApolloQueryWatcher is returned from the watch protocol method, but since this wasn't public there wasn't a way to instantiate one.

Thanks for the fix!

@designatednerd designatednerd merged commit 3fc6f10 into apollographql:master Sep 4, 2019
@designatednerd designatednerd added this to the 0.15.1 milestone Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@designatednerd designatednerd designatednerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mikaelbartlett @apollo-cla @designatednerd