Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2426 improve response code error api #3123

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Issue 2426 improve response code error api #3123

merged 5 commits into from
Jul 20, 2023

Conversation

dfperry5
Copy link
Contributor

Addressing Issue 2426:

  • Adding in a computed property on ResponseCodeError for GraphQL Error. It converts the data into a JSONObject and uses that to create a new GraphQL Error. If there is not a valid JSON response, graphQLError computed property return nil.

@netlify
Copy link

netlify bot commented Jul 15, 2023 •
edited
Loading

👷 Deploy request for apollo-ios-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 1f1fb35

@dfperry5 dfperry5 mentioned this pull request Jul 15, 2023
Closed
@dfperry5
Copy link
Contributor Author

dfperry5 commented Jul 16, 2023 •
edited
Loading

@AnthonyMDev mind checking this out? :)

AnthonyMDev
AnthonyMDev approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution! There just seems to be some odd whitespace that got committed in your unit tests. Would you mine cleaning up the added whitespace before we merge this?

@BobaFetters
Update ResponseCodeInterceptorTests.swift
2d42c53 
Fixing erroneous whitespace in unit test file
@BobaFetters
Update ResponseCodeInterceptorTests.swift
1f1fb35 
Fixing one final whitespace issue
@BobaFetters BobaFetters merged commit 5ddf770 into apollographql:main Jul 20, 2023
@BobaFetters BobaFetters linked an issue Jul 20, 2023 that may be closed by this pull request
Improve ResponseCodeError API #2426
Closed
@dfperry5
Copy link
Contributor Author

Apologies for my delay! Looks like @BobaFetters knocked it out (Thanks a ton!) :)

Happy to contribute in other ways too!

AnthonyMDev pushed a commit that referenced this pull request Aug 2, 2023
@dfperry5 @BobaFetters @AnthonyMDev
Issue 2426 improve response code error api (#3123)
426c672 
Co-authored-by: Zach FettersMoore <4425109+BobaFetters@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyMDev AnthonyMDev AnthonyMDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ResponseCodeError API
3 participants
@dfperry5 @AnthonyMDev @BobaFetters