Avoid having extra ? at the end of request url when queryItems are empty #1729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid having extra ? at the end of request url when queryItems are empty
Details
Currently
GraphQLGETTransformer
is used to create query items for GET request endpoint. If propertybody
of this struct is empty ( does not have value for a given key) such as:which leads to queryItems is empty. By doing
components.queryItems = queryItems
, then the url ends up to have extra ? at the end like following:https://this_is_sample/abcd?
instead ofhttps://this_is_sample/abcd
Fix
Only assign
queryItems
toURLComponent
when it is not empty