Fix Fulfilled fragment references not being fully qualified

Additional error noted in closed ticket 2949 #2949 (comment)
apollographql · May 30, 2023 · d2853f7 · d2853f7
1 parent 7ec19ca
commit d2853f7
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 21 deletions.
diff --git a/Sources/ApolloCodegenLib/Templates/SelectionSetTemplate.swift b/Sources/ApolloCodegenLib/Templates/SelectionSetTemplate.swift
@@ -484,13 +484,10 @@ struct SelectionSetTemplate {
     while next.next != nil {
       defer { next = next.next.unsafelyUnwrapped }
 
-      let selectionSetName = SelectionSetNameGenerator.generatedSelectionSetName(
-        from: selectionSet.scopePath.head,
-        to: next,
-        withFieldPath: selectionSet.entity.fieldPath.head,
-        removingFirst: selectionSet.scopePath.head.value.type.isRootFieldType,
-        pluralizer: config.pluralizer
-      )
+      let selectionSetName = fullyQualifiedGeneratedSelectionSetName(
+        for: selectionSet.typeInfo,
+        to: next
+      )      
 
       fulfilledFragments.append(selectionSetName)
     }
@@ -546,7 +543,6 @@ struct SelectionSetTemplate {
       from: typeInfo.scopePath.head,
       to: toNode,
       withFieldPath: typeInfo.entity.fieldPath.head,
-      removingFirst: false,
       pluralizer: config.pluralizer
     )
   }

diff --git a/...Tests/CodeGeneration/Templates/SelectionSet/SelectionSetTemplate_Initializers_Tests.swift b/...Tests/CodeGeneration/Templates/SelectionSet/SelectionSetTemplate_Initializers_Tests.swift
@@ -365,8 +365,8 @@ class SelectionSetTemplate_Initializers_Tests: XCTestCase {
           ],
           fulfilledFragments: [
             ObjectIdentifier(Self.self),
-            ObjectIdentifier(AllAnimal.self),
-            ObjectIdentifier(AllAnimal.AsAnimalUnion.self)
+            ObjectIdentifier(TestOperationQuery.Data.AllAnimal.self),
+            ObjectIdentifier(TestOperationQuery.Data.AllAnimal.AsAnimalUnion.self)
           ]
         ))
       }
@@ -430,8 +430,8 @@ class SelectionSetTemplate_Initializers_Tests: XCTestCase {
           ],
           fulfilledFragments: [
             ObjectIdentifier(Self.self),
-            ObjectIdentifier(AllAnimal.self),
-            ObjectIdentifier(AllAnimal.AsPet.self)
+            ObjectIdentifier(TestOperationQuery.Data.AllAnimal.self),
+            ObjectIdentifier(TestOperationQuery.Data.AllAnimal.AsPet.self)
           ]
         ))
       }
@@ -1116,7 +1116,7 @@ class SelectionSetTemplate_Initializers_Tests: XCTestCase {
           ],
           fulfilledFragments: [
             ObjectIdentifier(Self.self),
-            ObjectIdentifier(AllAnimal.self)
+            ObjectIdentifier(TestOperationQuery.Data.AllAnimal.self)
           ]
         ))
       }
@@ -1378,7 +1378,7 @@ class SelectionSetTemplate_Initializers_Tests: XCTestCase {
           ],
           fulfilledFragments: [
             ObjectIdentifier(Self.self),
-            ObjectIdentifier(AllAnimal.self),
+            ObjectIdentifier(TestOperationQuery.Data.AllAnimal.self),
             ObjectIdentifier(AnimalDetails.self)
           ]
         ))
@@ -1455,7 +1455,7 @@ class SelectionSetTemplate_Initializers_Tests: XCTestCase {
           ],
           fulfilledFragments: [
             ObjectIdentifier(Self.self),
-            ObjectIdentifier(AllAnimal.self),
+            ObjectIdentifier(TestOperationQuery.Data.AllAnimal.self),
             ObjectIdentifier(AnimalDetails.self)
           ]
         ))
@@ -1574,7 +1574,7 @@ class SelectionSetTemplate_Initializers_Tests: XCTestCase {
             ],
             fulfilledFragments: [
               ObjectIdentifier(Self.self),
-              ObjectIdentifier(AllAnimal.self)
+              ObjectIdentifier(TestOperationQuery.Data.AllAnimal.self)
             ]
           ))
         }
@@ -1633,7 +1633,7 @@ class SelectionSetTemplate_Initializers_Tests: XCTestCase {
             ],
             fulfilledFragments: [
               ObjectIdentifier(Self.self),
-              ObjectIdentifier(AllAnimal.self)
+              ObjectIdentifier(TestOperationQuery.Data.AllAnimal.self)
             ]
           ))
         }
@@ -1694,8 +1694,8 @@ class SelectionSetTemplate_Initializers_Tests: XCTestCase {
             ],
             fulfilledFragments: [
               ObjectIdentifier(Self.self),
-              ObjectIdentifier(AllAnimal.self),
-              ObjectIdentifier(AllAnimal.IfA.self)
+              ObjectIdentifier(TestOperationQuery.Data.AllAnimal.self),
+              ObjectIdentifier(TestOperationQuery.Data.AllAnimal.IfA.self)
             ]
           ))
         }
@@ -1756,7 +1756,7 @@ class SelectionSetTemplate_Initializers_Tests: XCTestCase {
             ],
             fulfilledFragments: [
               ObjectIdentifier(Self.self),
-              ObjectIdentifier(AllAnimal.IfA.Friend.self)
+              ObjectIdentifier(TestOperationQuery.Data.AllAnimal.IfA.Friend.self)
             ]
           ))
         }
@@ -1834,7 +1834,7 @@ class SelectionSetTemplate_Initializers_Tests: XCTestCase {
           ],
           fulfilledFragments: [
             ObjectIdentifier(Self.self),
-            ObjectIdentifier(AllAnimal.self),
+            ObjectIdentifier(TestOperationQuery.Data.AllAnimal.self),
             ObjectIdentifier(AnimalDetails.self)
           ]
         ))