feature: Add suffix to schema type filenames #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: 9d04abe4e703ef5acab42d0d URL: https://www.apollographql.com/docs/deploy-preview/9d04abe4e703ef5acab42d0d |
✅ Deploy Preview for apollo-ios-docc canceled.
|
AnthonyMDev
requested changes
Jan 16, 2025
Sources/AnimalKingdomAPI/AnimalKingdomAPI/Sources/Schema/CustomScalars/CustomDate.scalar.swift
Outdated
Show resolved
Hide resolved
Tests/ApolloCodegenTests/ApolloCodegenConfigurationCodableTests.swift
Outdated
Show resolved
Hide resolved
|
This PR already updated the codegen configuration documentation - Here it is in the docs preview for this PR. Is there another place in the docs to update? I'll take a look at the other two review comments now.. |
BobaFetters
approved these changes
Jan 21, 2025
AnthonyMDev
approved these changes
Jan 22, 2025
BobaFetters
pushed a commit
that referenced
this pull request
Jan 22, 2025
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Jan 22, 2025
BobaFetters
pushed a commit
that referenced
this pull request
Jan 22, 2025
92f94b4d feature: Add suffix to schema type filenames (#580) git-subtree-dir: apollo-ios-codegen git-subtree-split: 92f94b4d9556b71359fbe7a55c5bcdb6bc3249c0
BobaFetters
pushed a commit
that referenced
this pull request
Jan 22, 2025
…ype filenames git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 6501841 git-subtree-split: 92f94b4d9556b71359fbe7a55c5bcdb6bc3249c0
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#2598.
Users now have the codegen configuration option (
appendSchemaTypeFilenameSuffix) to have a suffix added to their schema type filenames. This will help resolve problems in Xcode where the name of a schema type and operation type are the same causing a build error.This new config option has a default value of
falsewhich means this should have no effect on users without the filename conflict error.