Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): looser name length #179

Merged
merged 11 commits into from
Aug 30, 2024
Merged

feat(core): looser name length #179

merged 11 commits into from
Aug 30, 2024

Conversation

bzp2010
Copy link
Collaborator

@bzp2010 bzp2010 commented Aug 29, 2024

Description

Loosen the name max length checking rules in schema.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible

@bzp2010 bzp2010 added the test/api7 Trigger the API7 test on the PR label Aug 29, 2024
@bzp2010 bzp2010 marked this pull request as ready for review August 30, 2024 07:37
juzhiyuan
juzhiyuan approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bzp2010 bzp2010 merged commit 6a8857c into main Aug 30, 2024
6 checks passed
@bzp2010 bzp2010 deleted the bzp/feat-loose-name-length branch October 12, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@guoqqqi guoqqqi guoqqqi approved these changes

@SkyeYoung SkyeYoung Awaiting requested review from SkyeYoung

@pottekkat pottekkat Awaiting requested review from pottekkat

Assignees
No one assigned
Labels
test/api7 Trigger the API7 test on the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzp2010 @juzhiyuan @guoqqqi