Split test requirements out and add constraint #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move test requirements into seperate requirements file to make it clearer that they are only needed for running unit tests. - Add constraints file called from the test requirements file to limit one of coveralls' dependencies to an ealier version that works with Python 2.6.
gregcorbett
reviewed
Sep 24, 2018
gregcorbett
previously approved these changes
Sep 26, 2018
|
I am happy to approve the changes, do you want to squash the commits down before I review though? |
gregcorbett
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The weekly cron build failed which raised an issue with a dependency of a dependency not supporting Python 2.6 any more. This PR fixes that (though the longer term fix is to deprecate Python 2.6 support).
clearer that they are only needed for running unit tests.
one of coveralls' dependencies to an earlier version that works with
Python 2.6.