Release 2.3.0 to master #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 2.2.1 to dev
* Add a Dockerfile to build a docker image of the SSM * Update README to explain the use of the SSM container
- we could (maybe) still support 3.0.X, but it's not pip installable and forces us to use SSLv2or3 which are outdated - compatibility tested on SL6 and SL7
- under v4, on_send is past a Frame object only rather than a dictionary of headers - on_send is now triggered on non APEL message messages (such as 'CONNECT' frames) and those messages do not have an empa-id. - unused_body is required to be backward compatibaly with the stopm.py v3 method signiture of on_send, even though it's not used.
- The method signature has changed to require the queue as the first argument
- in stomp.py v3, stop() just calls the disconnect() method anyway - in stomp.py v4, stop() just passes
- Despite being listed as an optional arguement, it seems id is required by stomp.py v4 - It doesn't seem to have any effect on stomp.py v3 as I believe it just gets added as a header that can be used or ignored depennding on underlying STOMP version (1.1+ seems to require it) - id based on the time to avoid any potential id clashes
- stomp.py v4 wants to call this method. - not having it causes lines to be logged in debug mode saying this method does not exist. - having it makes stomp.py less noisy in debug mode
- currently 3
- This reverts commit b1a8f6d as the use of uuid is probably overkill
- This reverts commit 7fabe1c so we can use a static ID instead as we only ever have one subscription within a connection
- because we only ever have one subscription within a connection and ID is only considered to differentiate subscriptions within a connection.
- so we can limit stomp.py logging to warning and above, as newer versions are more "noisy"
- as we would rarely want to see stomp.py in debug mode
- as in the versions of stomp.py we now support, this exception is called ConnectFailedException
Add support for stomp.py v3.1.6+, including stomp.py v4
- It seems python-daemon 2.2.0 released on 15/08/2018 breaks support for Python 2.6. - The obvious effect is the Travis tests and Docker build started to fail. - Constraining the package version should allow the tests and builds to pass as the latest 2.1.x version works on Python 2.6.
- ubuntu (and RedHat) seem to prefer this to file directly under /usr/share/doc/apel-ssm - and fpm errors because it seems to assume apel-ssm is a directory (see jordansissel/fpm#586)
- it is very RedHat/Centos/SL specific and whereas the setup.py script is meant to be a more general way of installing ssm - it also seems to cause problems with fpm and the packages generated by pleaserun as the bad init script conflicts with the unit files - add a note saying this script does not install init scripts
- as it mangle them and those it doesn't mangle aren't packages under ubunutu so need to be installed by pip
- as pip is needed to install the python requirements and the system python-ldap package is needed for the python python-ldap to install
- to prevent a nasty surprise on systems where python 3 is the default python
- in its previous location, it seemed to have no effect. - it has been moved to before any "depends" options
- following review
- rather than moving it
- as suggested by Codacy
- as it is not limited to amd64 style Ubuntu systems - `all` is the deb equivalent of `noarch`
Add build script to create .deb packages for Debian/Ubuntu style systems using FPM, changes to setup.py to facilitate this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May magically be approved if #76 is.