-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOMEE-4296 - MicroProfile JWT 2.1 #962
Conversation
@tichovz Thanks for the PR. Can you resolve the conflicts? |
I resolved the conflicts. |
@tichovz Can you re-base and update to the final artifact here? |
Yes, I will do it. |
I made the rebase and upgrade mp-jwt to 2.1 |
looks good to me |
Thanks @tichovz - I will get that in for you. Did run the mp-jwt tck locally and everything looks good. |
@tichovz Can you have a look at https://github.com/apache/tomee/blob/main/itests/microprofile-jwt-itests/src/test/java/org/apache/tomee/microprofile/jwt/itest/AllowNoExpPropertyTest.java Looks like it is failing due to this upgrade? Maybe we only need to adjust the test setup? As you are the person who have written that test, could you have a look ? |
Here is the Jira: https://issues.apache.org/jira/browse/TOMEE-4297 |
implement 'mp.jwt.verify.token.age' property
implement 'mp.jwt.verify.clock.skew' property
org.apache.tomee.microprofile.jwt.config.JWTAuthConfiguration expGracePeriodSecs maybe superfluous