Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOMEE-4296 - MicroProfile JWT 2.1 #962

Merged
merged 19 commits into from
Feb 2, 2024
Merged

Conversation

tichovz
Copy link
Contributor

@tichovz tichovz commented Nov 9, 2022

implement 'mp.jwt.verify.token.age' property
implement 'mp.jwt.verify.clock.skew' property
org.apache.tomee.microprofile.jwt.config.JWTAuthConfiguration expGracePeriodSecs maybe superfluous

@rzo1
Copy link
Contributor

rzo1 commented Nov 9, 2022

@tichovz Thanks for the PR. Can you resolve the conflicts?

@tichovz
Copy link
Contributor Author

tichovz commented Nov 9, 2022

I resolved the conflicts.

@rzo1
Copy link
Contributor

rzo1 commented Jan 19, 2024

@tichovz Can you re-base and update to the final artifact here?

@tichovz
Copy link
Contributor Author

tichovz commented Jan 22, 2024

@tichovz Can you re-base and update to the final artifact here?

Yes, I will do it.

@tichovz
Copy link
Contributor Author

tichovz commented Feb 1, 2024

I made the rebase and upgrade mp-jwt to 2.1

@tandraschko
Copy link
Member

looks good to me

@rzo1 rzo1 changed the title Microprofile jwt 2.1 rc6 TOMEE-4296 - MicroProfile JWT 2.1 Feb 2, 2024
@rzo1 rzo1 merged commit 61c6324 into apache:main Feb 2, 2024
@rzo1
Copy link
Contributor

rzo1 commented Feb 2, 2024

Thanks @tichovz - I will get that in for you. Did run the mp-jwt tck locally and everything looks good.

@rzo1
Copy link
Contributor

rzo1 commented Feb 2, 2024

@tichovz Can you have a look at https://github.com/apache/tomee/blob/main/itests/microprofile-jwt-itests/src/test/java/org/apache/tomee/microprofile/jwt/itest/AllowNoExpPropertyTest.java

Looks like it is failing due to this upgrade? Maybe we only need to adjust the test setup? As you are the person who have written that test, could you have a look ?

@rzo1
Copy link
Contributor

rzo1 commented Feb 2, 2024

Here is the Jira: https://issues.apache.org/jira/browse/TOMEE-4297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants