Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOMEE-4182] missing GitHub actions: adding builds for 9.x and inverting caches keys for main #1014

Merged
merged 1 commit into from
Jan 31, 2023
Merged

[TOMEE-4182] missing GitHub actions: adding builds for 9.x and inverting caches keys for main #1014

merged 1 commit into from
Jan 31, 2023

Conversation

sultan
Copy link
Contributor

@sultan sultan commented Jan 31, 2023 •
edited
Loading

i saw there is:

  • no GitHub actions for Pull Requests on branch 9.x (code in main branch)
  • inversions of PR and non PR keys for the GitHub cache on branch main

fixed 4 files

rzo1
rzo1 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@rzo1 rzo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should get that in.

@sultan sultan force-pushed the main-github-actions branch from ff0ed2a to cff4001 Compare January 31, 2023 13:06
@sultan sultan changed the title GitHub actions [TOMEE-4182]GitHub actions: adding builds for 9.x and inverting caches keys for main Jan 31, 2023
@sultan sultan force-pushed the main-github-actions branch from cff4001 to d771a3d Compare January 31, 2023 13:43
@sultan sultan marked this pull request as ready for review January 31, 2023 13:44
@sultan sultan changed the title [TOMEE-4182]GitHub actions: adding builds for 9.x and inverting caches keys for main [TOMEE-4182] missing GitHub actions: adding builds for 9.x and inverting caches keys for main Jan 31, 2023
@sultan
Copy link
Contributor Author

sultan commented Jan 31, 2023

reworded the commit to include the jira issue number

@sultan
Copy link
Contributor Author

sultan commented Jan 31, 2023

maybe i missed the fact that such files must be on the targeted branch.
i am not sure on the conditions of execution.

lets see if its ok and if not i'll have to move files:
branch main: main-xxx files
tomee-9.x: tomee-9.x-xxx files
tomee-8.x: tomee-8.x-xxx files

@sultan sultan force-pushed the main-github-actions branch from d771a3d to 0c31f4b Compare January 31, 2023 14:24
@rzo1 rzo1 merged commit 59585b1 into apache:main Jan 31, 2023
@rzo1
Copy link
Contributor

rzo1 commented Jan 31, 2023

thx

@sultan sultan deleted the main-github-actions branch January 31, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzo1 rzo1 rzo1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sultan @rzo1