Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix agent file error #34412

Merged
merged 2 commits into from
Jan 21, 2025
+6 −9
Merged

Fix agent file error #34412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32c612c
Fix agent file error
jiangML Jan 20, 2025
79a8f81
Fix agent file error
jiangML Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...apache/shardingsphere/agent/plugin/logging/file/advice/MetaDataContextsFactoryAdvice.java
View file
Original file line number Diff line number Diff line change
@@ -19,24 +19,25 @@

import lombok.extern.slf4j.Slf4j;
import org.apache.shardingsphere.agent.api.advice.TargetAdviceMethod;
import org.apache.shardingsphere.agent.plugin.core.advice.AbstractStaticMethodAdvice;
import org.apache.shardingsphere.agent.api.advice.TargetAdviceObject;
import org.apache.shardingsphere.agent.plugin.core.advice.AbstractInstanceMethodAdvice;
import org.apache.shardingsphere.agent.plugin.core.recorder.MethodTimeRecorder;

/**
* Meta data contexts factory advice.
*/
@Slf4j
public final class MetaDataContextsFactoryAdvice extends AbstractStaticMethodAdvice {
public final class MetaDataContextsFactoryAdvice extends AbstractInstanceMethodAdvice {

private final MethodTimeRecorder methodTimeRecorder = new MethodTimeRecorder(MetaDataContextsFactoryAdvice.class);

@Override
public void beforeMethod(final Class<?> clazz, final TargetAdviceMethod method, final Object[] args, final String pluginType) {
public void beforeMethod(final TargetAdviceObject target, final TargetAdviceMethod method, final Object[] args, final String pluginType) {
methodTimeRecorder.recordNow(method);
}

@Override
public void afterMethod(final Class<?> clazz, final TargetAdviceMethod method, final Object[] args, final Object result, final String pluginType) {
public void afterMethod(final TargetAdviceObject target, final TargetAdviceMethod method, final Object[] args, final Object result, final String pluginType) {
log.info("Build meta data contexts finished, cost {} milliseconds.", methodTimeRecorder.getElapsedTimeAndClean(method));
}
}
6 changes: 1 addition & 5 deletions agent/plugins/logging/type/file/src/main/resources/META-INF/conf/file-advisors.yaml
View file
Original file line number Diff line number Diff line change
@@ -16,15 +16,11 @@
#

advisors:
- target: org.apache.shardingsphere.mode.metadata.MetaDataContextsFactory
- target: org.apache.shardingsphere.mode.metadata.factory.MetaDataContextsFactory
advice: org.apache.shardingsphere.agent.plugin.logging.file.advice.MetaDataContextsFactoryAdvice
pointcuts:
- name: create
type: method
params:
- index: 0
type: org.apache.shardingsphere.mode.metadata.persist.MetaDataPersistService
- index: 1
type: org.apache.shardingsphere.mode.manager.ContextManagerBuilderParameter
- index: 2
type: org.apache.shardingsphere.infra.instance.ComputeNodeInstanceContext