Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cluster-mode-example with ShardingSphereDriver #22542

Merged
merged 7 commits into from
Nov 30, 2022

Conversation

Pace2Car
Copy link
Contributor

For #22469.

Changes proposed in this pull request:

  • Refactor cluster-mode-example with ShardingSphereDriver
  • Remove Spring configuration example

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@codecov-commenter
Copy link

Codecov Report

Merging #22542 (12c1fd5) into master (ee7db7d) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #22542      +/-   ##
============================================
- Coverage     50.98%   50.93%   -0.05%     
- Complexity     2514     2515       +1     
============================================
  Files          4185     4189       +4     
  Lines         58237    58289      +52     
  Branches       9902     9912      +10     
============================================
- Hits          29694    29692       -2     
- Misses        26013    26066      +53     
- Partials       2530     2531       +1     
Impacted Files Coverage Δ
...handler/distsql/ral/hint/enums/HintSourceType.java 0.00% <0.00%> (-42.86%) ⬇️
...trics/prometheus/collector/BuildInfoCollector.java 62.50% <0.00%> (-6.25%) ⬇️
...eger/definition/JaegerPluginDefinitionService.java 88.88% <0.00%> (-5.23%) ⬇️
...pkin/definition/ZipkinPluginDefinitionService.java 88.88% <0.00%> (-5.23%) ⬇️
...definition/OpenTracingPluginDefinitionService.java 88.88% <0.00%> (-5.23%) ⬇️
...n/OpenTelemetryTracingPluginDefinitionService.java 88.88% <0.00%> (-5.23%) ⬇️
.../definition/PrometheusPluginDefinitionService.java 47.61% <0.00%> (-2.39%) ⬇️
...rometheus/service/PrometheusPluginBootService.java 66.66% <0.00%> (-1.34%) ⬇️
...re/agent/core/plugin/PluginBootServiceManager.java 0.00% <0.00%> (ø)
...pi/definition/AbstractPluginDefinitionService.java 0.00% <0.00%> (ø)
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RaigorJiang RaigorJiang merged commit f6a202b into apache:master Nov 30, 2022
@Pace2Car Pace2Car deleted the refactor-cluster-mode-example branch November 30, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants