Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sharding example with ShardingSphereDriver #22513

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

Pace2Car
Copy link
Contributor

@Pace2Car Pace2Car commented Nov 29, 2022

For #22469.

Changes proposed in this pull request:

  • Refactor configuration to use ShardingSphereDriver
  • Remove Spring configuration example

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@RaigorJiang
Copy link
Contributor

@Pace2Car Thank you!

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.98%. Comparing base (38f7e45) to head (87f99f6).
Report is 8036 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #22513      +/-   ##
============================================
- Coverage     51.05%   50.98%   -0.08%     
- Complexity     2512     2514       +2     
============================================
  Files          4179     4185       +6     
  Lines         58109    58237     +128     
  Branches       9891     9902      +11     
============================================
+ Hits          29670    29691      +21     
- Misses        25911    26016     +105     
- Partials       2528     2530       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaigorJiang RaigorJiang merged commit 935a810 into apache:master Nov 29, 2022
@Pace2Car Pace2Car deleted the refactor-remove-spring branch November 30, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants