Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ShardingSphere-JDBC start up fail when use non-HikariCP pool. #15611

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Fixed ShardingSphere-JDBC start up fail when use non-HikariCP pool. #15611

merged 2 commits into from
Feb 25, 2022

Conversation

zhaojinchao95
Copy link
Contributor

Fixes #15563
For #15507

@zhaojinchao95 zhaojinchao95 marked this pull request as draft February 24, 2022 08:57
@zhaojinchao95 zhaojinchao95 added this to the 5.1.1 milestone Feb 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #15611 (ae980a5) into master (f92142b) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #15611      +/-   ##
============================================
- Coverage     60.47%   60.42%   -0.05%     
+ Complexity     1992     1763     -229     
============================================
  Files          3240     3242       +2     
  Lines         48753    48823      +70     
  Branches       8329     8345      +16     
============================================
+ Hits          29483    29502      +19     
- Misses        16852    16897      +45     
- Partials       2418     2424       +6     
Impacted Files Coverage Δ
...metadata/type/dbcp/DBCPDataSourcePoolMetaData.java 100.00% <100.00%> (ø)
...ta/type/dbcp/TomcatDBCPDataSourcePoolMetaData.java 100.00% <100.00%> (ø)
...data/type/hikari/HikariDataSourcePoolMetaData.java 100.00% <100.00%> (ø)
...mmand/query/simple/PostgreSQLComQueryExecutor.java 58.97% <0.00%> (-23.79%) ⬇️
.../query/text/query/MySQLComQueryPacketExecutor.java 52.00% <0.00%> (-18.59%) ⬇️
...l/command/query/builder/ResponsePacketBuilder.java 90.90% <0.00%> (-4.33%) ⬇️
...end/postgresql/err/PostgreSQLErrPacketFactory.java 48.00% <0.00%> (-4.18%) ⬇️
...ackend/text/TextProtocolBackendHandlerFactory.java 61.11% <0.00%> (-2.36%) ⬇️
...roxy/frontend/mysql/err/MySQLErrPacketFactory.java 61.11% <0.00%> (-2.36%) ⬇️
.../db/protocol/mysql/constant/MySQLCharacterSet.java 99.00% <0.00%> (-0.30%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f92142b...ae980a5. Read the comment docs.

@zhaojinchao95 zhaojinchao95 marked this pull request as ready for review February 25, 2022 03:22
Copy link
Member

@terrymanu terrymanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove pom dependencies too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception in getting data source from jfinal integration
3 participants