Skip to content

Block elasticjob-spring-boot-starter from passing spring-boot-starter test scope dependencies #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

linghengqian
Copy link
Member

Fixes #2418.

Changes proposed in this pull request:

  • Block elasticjob-spring-boot-starter from passing spring-boot-starter test scope dependencies.
  • Update missing documentation.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (a8ba448) to head (5b406f4).
Report is 35 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2421      +/-   ##
============================================
- Coverage     80.10%   79.61%   -0.50%     
+ Complexity     1113     1106       -7     
============================================
  Files           204      204              
  Lines          3821     3806      -15     
  Branches        445      443       -2     
============================================
- Hits           3061     3030      -31     
- Misses          570      585      +15     
- Partials        190      191       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@strongduanmu strongduanmu merged commit c17a3e5 into apache:master Aug 10, 2024
16 checks passed
@linghengqian linghengqian deleted the fix-spring-boot-3 branch August 10, 2024 08:23
@linghengqian linghengqian added this to the 3.1.0 milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The elasticjob-spring-boot-starter module should not pass spring-boot-starter dependencies downstream
3 participants