Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9196] Broker return pop stats when receive notification #9197

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9196

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 48.03%. Comparing base (a275510) to head (c94ea10).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
.../apache/rocketmq/client/consumer/NotifyResult.java 0.00% 8 Missing ⚠️
.../rocketmq/client/impl/mqclient/MQClientAPIExt.java 0.00% 6 Missing ⚠️
...cketmq/broker/processor/NotificationProcessor.java 0.00% 4 Missing ⚠️
...ng/protocol/header/NotificationResponseHeader.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9197      +/-   ##
=============================================
+ Coverage      47.98%   48.03%   +0.04%     
- Complexity     12072    12089      +17     
=============================================
  Files           1321     1322       +1     
  Lines          93024    93049      +25     
  Branches       11926    11924       -2     
=============================================
+ Hits           44638    44694      +56     
+ Misses         42880    42830      -50     
- Partials        5506     5525      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

*/
package org.apache.rocketmq.client.consumer;

public class NotifyResult {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里我倒是建议用 Pair 去写,减少不必要的对象和阅读的复杂性

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Broker return pop stats when receive notification
4 participants