Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8164] Log more accurate for the MQClientInstance#doRebalance #8165

Merged
merged 1 commit into from
May 20, 2024

Conversation

miles-ton
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8164

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.90%. Comparing base (9bdc9db) to head (56b4bbf).

Files Patch % Lines
...rocketmq/client/impl/factory/MQClientInstance.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8165      +/-   ##
=============================================
- Coverage      42.93%   42.90%   -0.04%     
+ Complexity     10372    10366       -6     
=============================================
  Files           1270     1270              
  Lines          88689    88689              
  Branches       11402    11402              
=============================================
- Hits           38077    38048      -29     
- Misses         45915    45937      +22     
- Partials        4697     4704       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma merged commit 0ad0244 into apache:develop May 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] make log more accurate fot the MQClientInstance#doRebalance
4 participants