[improve][meta] Stop election operations when LeaderElectionImpl gets closed #23995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
force-pushed
the
lh-fix-LeaderElectionImpl-close
branch
from
2d4c72e to
a62e10a
Compare
dao-jun
reviewed
Feb 18, 2025
| @@ -113,6 +116,11 @@ private synchronized CompletableFuture<LeaderElectionState> elect() { | |||
| return tryToBecomeLeader(); | |||
| } | |||
| }).thenCompose(leaderElectionState -> { | |||
| synchronized (this) { | |||
| if (internalState == InternalState.Closed) { | |||
There was a problem hiding this comment.
Need to add volatile on internalState?
There was a problem hiding this comment.
Already covered with synchronized (this). this points to LeaderElectionImpl instance here.
|
Fixing a potentially flaky test that uses a bad way to trigger leader election. |
lhotari
added
release/3.3.6
release/3.0.11
release/4.0.4
and removed
release/3.3.5
release/3.0.10
release/4.0.3
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some tests, I noticed that LeaderElectionImpl could continue to make operations and override the closed state.
Modifications
Add checks if the internalState is Closed
Documentation
docdoc-requireddoc-not-neededdoc-complete