Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][improve][ci] Enable Netty leak detection in CI and make leaks fail the build #23956

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Feb 10, 2025

Motivation

To prevent future memory leak regressions, it's useful to Netty leak detection enabled in CI and make leaks fail the build.

Modifications

  • add custom io.netty.util.ResourceLeakDetector implementation that logs leaks to files
  • configure Netty leak detector for unit tests and integration tests
  • show detected leaks directly in GitHub Action UI and make log records downloadable

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: lhotari#201

@lhotari lhotari added this to the 4.1.0 milestone Feb 10, 2025
@lhotari lhotari self-assigned this Feb 10, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 10, 2025
@lhotari lhotari force-pushed the lh-enable-netty-leak-detection-in-tests branch 2 times, most recently from c4a0049 to 171626c Compare February 12, 2025 11:29
@lhotari lhotari force-pushed the lh-enable-netty-leak-detection-in-tests branch 2 times, most recently from 0eb3ae3 to 9fae251 Compare February 12, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant