Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Prevent OOM in test by not spying invocations in SimpleProducerConsumerTest #23486

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 19, 2024

Motivation

Modifications

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

…oducerConsumerTest

- it's not necessary to spy invocations that consume a lot of memory
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (bbc6224) to head (994dadc).
Report is 691 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23486      +/-   ##
============================================
+ Coverage     73.57%   74.29%   +0.72%     
- Complexity    32624    34292    +1668     
============================================
  Files          1877     1943      +66     
  Lines        139502   146973    +7471     
  Branches      15299    16191     +892     
============================================
+ Hits         102638   109199    +6561     
- Misses        28908    29345     +437     
- Partials       7956     8429     +473     
Flag Coverage Δ
inttests 27.45% <ø> (+2.86%) ⬆️
systests 24.38% <ø> (+0.06%) ⬆️
unittests 73.66% <ø> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 645 files with indirect coverage changes

@Technoboy- Technoboy- merged commit 7367f1c into apache:master Oct 21, 2024
55 of 57 checks passed
@lhotari
Copy link
Member Author

lhotari commented Oct 21, 2024

Finding the test that was running when the heap dump was created can be found in Eclipse MAT with OQL query select * from org.testng.internal.TestResult where m_status = 16

image

@lhotari
Copy link
Member Author

lhotari commented Oct 21, 2024

Getting registered invocations with Eclipse MAT Calcite SQL query that are contributing to the OOM:

select SUM(invocationCount) AS total_invocations, m from (select cast(registeredInvocations['invocations']['size'] as integer) as invocationCount, toString(invocationForStubbing['invocation']['realMethod']['origin']) as m from org.mockito.internal.stubbing.InvocationContainerImpl) group by m order by 1
image

lhotari added a commit that referenced this pull request Oct 22, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants