Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make subscribe for TopicsConsumer using builder #1237

Closed
zhaijack opened this issue Feb 14, 2018 · 1 comment
Closed

Make subscribe for TopicsConsumer using builder #1237

zhaijack opened this issue Feb 14, 2018 · 1 comment

Comments

@zhaijack
Copy link
Contributor

Following PIP-12, we should turn to use builder for creating TopicsConsumer.
@zhaijack zhaijack mentioned this issue Feb 14, 2018
Merged
@zhaijack
Copy link
Contributor Author

PR #1269 is for this

merlimat pushed a commit that referenced this issue Feb 22, 2018
@zhaijack @merlimat
Issue #1237: support builder for topicsConsumer (#1269)
68cd115 
* support builder for topicsConsumer

* change following @Matteo's comments to remove subscribe methods in client

* change to topic(String ... names) for consumer builder

* change following @sijie's comments
@zhaijack zhaijack closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhaijack