Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PARQUET-1777: add Parquet logos #157

Closed
wants to merge 2 commits into from
Closed

PARQUET-1777: add Parquet logos #157

wants to merge 2 commits into from

Conversation

julienledem
Copy link
Member

@julienledem julienledem commented Jan 24, 2020 •
edited
Loading

Make sure you have checked all steps below.

Jira

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • No new functionality

@julienledem julienledem requested a review from xhochy January 24, 2020 17:30
Fokko
Fokko approved these changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@xhochy xhochy closed this in 890af22 Jan 28, 2020
@xhochy xhochy deleted the add_logos branch January 28, 2020 05:37
@xhochy xhochy mentioned this pull request Jan 28, 2020
Open
3 tasks
@wesm
Copy link
Member

wesm commented Jan 28, 2020

Do we need to create logos that have "Apache" in them?

@asfimport asfimport mentioned this pull request Jun 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy approved these changes

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienledem @wesm @xhochy @Fokko