Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid activating TopComponents while focus changes in progress. #8288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

errael
Copy link
Contributor

@errael errael commented Mar 2, 2025

Fix #7952.

  • Use invokeLater() so KeyboardFocusManager changes are finished before possible activation. After focus is settled, do nothing if the original target is not currently focused.
  • Use permanentFocusOwner property (instead of focusOwner) for minor optimization.

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

Fix apache#7952.

Use invokeLater() so KeyboardFocusManager changes are finished.
Use "permanentFocusOwner" property (instead of "focusOwner") for minor optimization.
@errael
Copy link
Contributor Author

errael commented Mar 3, 2025

@nmatt could you try this out?

@nmatt
Copy link

nmatt commented Mar 3, 2025

@errael Yes, of course, but I need a pointer of what to install. Is the zip of the daily build under https://ci-builds.apache.org/job/Netbeans/job/netbeans-linux/lastSuccessfulBuild/artifact/nbbuild/ the correct thing to use? Also, thanks for looking into this issue.

@errael
Copy link
Contributor Author

errael commented Mar 3, 2025

Yes, of course, but I need a pointer of what to install. Is the zip of the daily build under https://ci-builds.apache.org/job/Netbeans/job/netbeans-linux/lastSuccessfulBuild/artifact/nbbuild/ the correct thing to use? Also, thanks for looking into this issue.

This follow on to #4603 is ready for review. You'd have to include this PR in your own build of NB to check it out. Looking for reviewers. @neilcsmith-net, @eirikbakke any suggestions?

@nmatt
Copy link

nmatt commented Mar 3, 2025

@errael I have no experience with building NetBeans, I'm not sure how straightforward that would be for me. If someone could provide me with a build to test, that would preferable. I'm on Windows, in case that makes a difference.

@errael
Copy link
Contributor Author

errael commented Mar 4, 2025

I have no experience with building NetBeans, I'm not sure how straightforward that would be for me. If someone could provide me with a build to test, that would preferable. I'm on Windows, in case that makes a difference.

I understand; no problem. Hoping someone will notice this and review...

Just remembered box. I just built and uploaded; there's https://app.box.com/s/n53caj9p8bkilxwv2tk9k95nmgsagbus I'll leave it around for a couple days.

Don't know about security with this; I've attached a sha512 checksum to this message.

NetBeans-dev-20250303-unknown-revn-basic.zip.sha512.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

focus bug when accessing main menu from floating pane
2 participants