Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit relative paths and class names as 'mainClass' setting in launch.json. #8280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Feb 27, 2025

Currently, if the launch.json contains mainClass, the value must be an absolute path. This patch adds the possibility to specify a relative path, or a (top-level) class name.

@lahodaj lahodaj added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Feb 27, 2025
@lahodaj lahodaj added this to the NB26 milestone Feb 27, 2025
Copy link
Contributor

@dbalek dbalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine.
Do not forget to modify also the attribute description - see https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/package.json#L295

@lahodaj lahodaj force-pushed the relative-path-mainClass-in-launch-json branch from d35e058 to 744ccd3 Compare February 28, 2025 08:38
@lahodaj
Copy link
Contributor Author

lahodaj commented Feb 28, 2025

Fine. Do not forget to modify also the attribute description - see https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/package.json#L295

Thanks! Description updated (and force pushed).

@lahodaj lahodaj marked this pull request as ready for review February 28, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants