Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No wait cursor on CSL navigator expand #8274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −3
Open

No wait cursor on CSL navigator expand #8274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ide/csl.api/src/org/netbeans/modules/csl/navigation/ClassMemberPanelUI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ public ClassMemberPanelUI(final Language language) {
initComponents();

// Tree view of the elements
elementView = createBeanTreeView();
elementView = createBeanTreeView();
elementView.setAutoWaitCursor(false);
add(elementView, BorderLayout.CENTER);

filters = new ClassMemberFilters( this );
Expand Down Expand Up @@ -302,7 +303,6 @@ public void run() {
public void run() {
long startTime = System.currentTimeMillis();
elementView.setRootVisible(false);
elementView.setAutoWaitCursor(false);
manager.setRootContext(new ElementNode( description, ClassMemberPanelUI.this, fileObject ) );

int expandDepth = -1;
Expand All @@ -328,7 +328,6 @@ public void run() {
elementView.setScrollOnExpand( scrollOnExpand );
}
});
elementView.setAutoWaitCursor(true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing against this but we should try to keep functionality in sync across the codebase.

the java navigator has the same disable/enable trick in the refresh method:

netbeans/java/java.navigation/src/org/netbeans/modules/java/navigation/ClassMemberPanelUI.java

Lines 427 to 429 in b2bdb81

elementView.setAutoWaitCursor(false);
elementView.expandAll();
elementView.setAutoWaitCursor(true);

(there are no other usages looks like)

I think I can see the cursor change for a split second when I toggle collapse/expand in the java navigator.

Disabling the cursor change should be fine UX-wise, since the tree itself has a please-wait placeholder node for situations where it takes longer until the file structure is available.

long endTime = System.currentTimeMillis();
Logger.getLogger("TIMER").log(Level.FINE, "Navigator Initialization",
new Object[] {fileObject, endTime - startTime});
Expand Down
Loading