In Surround with try-catch hint add/default to System.Logger.

[errael]

This default is also used by Generate > Logger.... Addresses some issues in raised in #8240.
New feature Use existing declared Logger. Fix Logging hints to handle System.Logger.
Add "Put string concatenation in lambda" hint fix. Adjust tests; new tests.

---

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

• are all your own work, and you have the right to contribute them.
• are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

1. Was this PR correctly labeled, did the right tests run? When did they run?
2. Is this PR squashed?
3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

[errael]

Notes/issues/questions about this PR.

"java.lang.System.Logger" is used directly because:

System.Logger.class.getName() is "java.lang.System$Logger", note '$',
and "...getQualifiedName().contentEquals" fails, so use litteral class name.

Generate > Logger... requires knowing which kind of logger. That information is only specified in Hints > ErrorFixes > SurroundWithTryCatch. It's weird to be looking into the hints this way, but otherwise some entirely new UI is required. The PR uses FileHintPreferences to grab this info, I've never used it before so this code should be carefully reviewed.
See org.netbeans.modules.java.editor.codegen.LoggerGenerator.isUseSystemLogger

Using System.Logger with code that currently uses java.util.logging works seamlessly when using the default System.LoggerFinder. Agree?

// NOI18N doesn't seem to be used consistently; assuming it's no longer required.

[errael]

@lahodaj The code for this PR is all about Hints and Generate>Logger; java.compiler and NB's ...api.java.source stuff (relatively unfamiliar to me). The small OP and 1st comment mention possible issues; any comments about these appreciated. (of course a review would be terrific)