-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #8087-Unable to add new web service client #8228
base: master
Are you sure you want to change the base?
Conversation
maven-war-plugin -Add support for jakarta namespaces for Jakarta EE 9 and later -Change jax-ws group id to 'com.sun.xml.ws' -Add instance variables to 'JaxWsClientCreator' that will help with the new logic to support jakarta namespaces and reduce method calls -Use constants when possible -Use diamond inference -Use try-with-resources -Increase array size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! In general looks sane to me. I left inline comments.
|
||
public static final String MAVEN_PLUGINS_GROUP_ID = "org.apache.maven.plugins"; //NOI18N | ||
public static final String WAR_PLUGIN_ARTIFACT_ID = "maven-war-plugin"; //NOI18N | ||
public static final String WAR_PLUGIN_VERSION = "2.3.4"; //NOI18N |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would bump to 3.4.0
if there is not a very good reason to stay on the old version. I remember that I bumped several projects to a 3.X version as 2.X failed when used with JDK 21+
@@ -59,14 +58,28 @@ | |||
*/ | |||
public final class MavenModelUtils { | |||
|
|||
private static Profile profile; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will become a problem. If you have one maven project with JakartaEE and one with JavaEE open, both will use the same profile
. You will need to pass the "isJakarta" property (or the profile) from the external entry points, to decide per call.
A passing question: is it save to assume this is only called for JavaEE/JakarataEE projects? If it is called for JavaSE projects, there will be no profile.
Fix issue 8087
NetBeans Notes:
com.sun.xml.ws
JaxWsClientCreator
that will help with the new logic to support jakarta namespaces and reduce method callsNetBeans Testing:
maven.jaxws
Web Service from WSDL
Jakarta EE 8



Jakarta EE 9
Jakarta EE 10