Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix database properties directory #8222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix database properties directory #8222

wants to merge 1 commit into from
+247 −137

Conversation

petrovic-d
Copy link
Collaborator

  • Temp files are now saved under temp directory
  • Make temp files read-only by default
  • Copying files to remote with one scp command (one handshake)
  • Extracted run-container script in handlebar template

@petrovic-d petrovic-d added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests enterprise [ci] enable enterprise job labels Feb 3, 2025
@apache apache locked and limited conversation to collaborators Feb 3, 2025
@apache apache unlocked this conversation Feb 3, 2025
@petrovic-d petrovic-d added this to the NB26 milestone Feb 4, 2025
@petrovic-d petrovic-d self-assigned this Feb 4, 2025
MartinBalin
MartinBalin approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@MartinBalin MartinBalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested with 2 projects and userdir Global/Local. Files are created in tmp folder and removed when Debug session ends.

@petrovic-d petrovic-d force-pushed the fix-database-properties-directory branch from 7274ee1 to 4d6d272 Compare February 24, 2025 08:49
thurka
thurka reviewed Feb 24, 2025
View reviewed changes
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/TempFileGenerator.java Outdated
@@ -129,20 +132,33 @@ private static interface WriterConsumer {

}

private Path generateConfigFile() throws IOException {
Path dir = generateDirPath();
private Path generateConfigFile() throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid white-space changes. They make review more dificult.

thurka
thurka requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@thurka thurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The java part have some minor issues, otherwise it looks good.

@petrovic-d petrovic-d force-pushed the fix-database-properties-directory branch from 4d6d272 to 58bb84a Compare February 25, 2025 09:14
@petrovic-d petrovic-d requested a review from thurka February 25, 2025 09:15
thurka
thurka approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@thurka thurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java part looks OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thurka thurka thurka approved these changes

@MartinBalin MartinBalin MartinBalin approved these changes

@jhorvath jhorvath Awaiting requested review from jhorvath

Assignees

@petrovic-d petrovic-d

Labels
enterprise [ci] enable enterprise job LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Milestone
NB26
Development

Successfully merging this pull request may close these issues.
4 participants
@petrovic-d @thurka @MartinBalin @neilcsmith-net