-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NB Build: Basic support for javac.release property. #7188
Conversation
69b2833
to
e73d553
Compare
646faef
to
ffead33
Compare
all green except paperwork |
ffead33
to
646ff4f
Compare
646ff4f
to
f14c088
Compare
f14c088
to
5a446b7
Compare
- javac release option support for Ant NBM projects - update custom javac and sigtest tasks
5a446b7
to
0a64c81
Compare
this PR now only contains the changes to the build system and is targeting NB 22. Part 2 for NB 23 would be in #7247 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible to me.
gave this a bit more testing:
this however did not work:
this likely indicates that the editor is using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's Ok to merge, and fix the API usage later on. It affects the module developers only. Speaking of me I can live with that.
I tracked it down to this which returns null: netbeans/java/java.source.base/src/org/netbeans/modules/java/source/parsing/JavacParser.java Line 960 in 8cc5215
netbeans/java/java.source.base/src/org/netbeans/modules/java/source/parsing/JavacParser.java Lines 1098 to 1100 in 8cc5215
because validatedSourceLevel is the same as the requested source level. If I let it return the requested source level instead of null, the javac task will set relaese and there will be error badges, however this causes exceptions somewhere else. Lets not do that. Going to merge, thanks for the reviews. |
JarWithModuleAttributes
too, which sets theOpenIDE-Module-Java-Dependencies
manifest attribute based on the language levelapisupport.ant
) needed to be made aware of the javac release propertyapisupport.ant
of NB 21 loads all projects which usejavac.release
as java 1.4 projects, if we get this into NB 22 and devs start using the new release, we can start swapping outsource/target
withrelease
during the NB 23 dev cycle.