DAP and LSP use a common Lookup. #5742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
LSP
|
Added a test to check that the default Lookup contents is present just once in commands, despite the proxies to proxies :) |
MartinBalin
approved these changes
Mar 30, 2023
dbalek
approved these changes
Mar 30, 2023
sdedic
force-pushed
the
lsp/dap-lsp-commonlookup
branch
from
73284e9 to
8a59dc3
Compare
|
I needed to change the way how the lookup extraction command hooks into the lookup. When I used MockLookup, it interfered with the default Lookup and prevented the module system from starting, so that Indexing support did not run its |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user code is run/debug, DAP protocol is used for the launch request. Although the DAP server provided
OperationContextfor reporting progress, it did not provide any other LSP client's functions to the DAP-initiated processes within NBLS.So when one runs (using codelen or command) a project or main class in a Maven project, with bad proxy settings, the Maven support wants to ask the user - and fails, since the DAP-initiated maven build has no access to
DialogDisplayerthat works through LSP connection with the LSP client to display confirmations.This PR attempts to change DAP + LSP implementation so that the default Lookup for their request processing conains both DAP and LSP lookups (and of course request-specific items and the default Lookup as the last one).