Initial HCL Support

[lkishalmi]

Well, I've restarted my HCL/Terraform Support efforts. This is just the base lexer supporting tfvar files, though the lexer, I hope, would work correctly on any HCL files. Parsers are in progress.

@matthiasblaesing could you have a glimpse on the licensing please?

The Terraform icon svg is coming from https://github.com/PKief/vscode-material-icon-theme/ repository. I kept the original as vscode-terraform.svg. Unfortunately it seems if I keep the name as terraform.svg the IDE would use that one over the png and fails as the svg has no size information.

[matthiasblaesing]

For the icon, I would suggest this approach:

matthiasblaesing@7d52293

• License information was put directly into the SVG. This should still be ok, as we are required to provide the license, but that is done through the file itself.
• I renamed the svg to match the png and modified the SVG to make it possible to use it as icon source in NetBeans

[lkishalmi]

@matthiasblaesing Thanks for the SVG! It seems to work, so I've removed the licenseinfo.xml and the derived png.
I think the nbbuild/licenses/MIT-vscode-material-icon-theme is still into the play, is it?

[matthiasblaesing]

@matthiasblaesing Thanks for the SVG! It seems to work, so I've removed the licenseinfo.xml and the derived png. I think the nbbuild/licenses/MIT-vscode-material-icon-theme is still into the play, is it?

I think we have no instance of icons where we only store the SVG version. Providing a png fallback makes it possible for people to run without batik, to keep it common, IMHO you should keep the png.

[matthiasblaesing]

For the commit validation problem on JDK 8, I suggest to drop javac.target from project.properties and change javac.source to 8. The javac task is modified to switch to using the release flag instead of target/source.

[mbien]

@lkishalmi I think @matthiasblaesing meant to downgrade the property to 8. You can't remove the properties otherwise NB won't know what language level the module has and everything will be red in the editor.

basically:
javac.source=1.8 and either remove target or set it to the same value which is fine too (I would recommend to set both so that it is nb-javac independent).

edit: i actually started working on providing a default value for everything - but got stuck and distracted by other things #5455

[lkishalmi]

Well, this one is far from being complete. I even question some of my design decisions, though the base HCL lexer was as close to the (specs)[https://github.com/hashicorp/hcl/blob/main/hclsyntax/spec.md] as I could get.

I'm not so sure that I'd keep the TerraformLexer, most probably it would be better to have parser adjusted highlight for different HCL flavors, but till I get there it is how it is.

The AST classes are also some very early implementations.

Anyway, the implementation works providing syntax highlight and folding for tfvars and tf files:

It also adds code templates for Terraform files.

[mbien]

looks good to me. Haven't reviewed the grammar files.