Fix increment on maven and java.editor.lib module for NB18 #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcsmith-net
added
the
Release process
neilcsmith-net
added
the
do not merge
sdedic
approved these changes
Feb 2, 2023
neilcsmith-net
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes increment on
mavenandjava.editor.libmodules for NB18. Both were missed by the increment Ant task used for #5312 due to use of a colon to separate key and value. Maven module syntax was fixed in later PR for 17, but needs an additional increment for NB18.See #5352 (comment)
Code that doesn't work with colon is at https://github.com/apache/netbeans/blob/master/nbbuild/antsrc/org/netbeans/nbbuild/IncrementSpecificationVersions.java#L96 Of course, that could also be used as a deliberate way of bypassing increment?!