Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced a part of replaceAll() calls to replace() #5228

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Replaced a part of replaceAll() calls to replace() #5228

merged 1 commit into from
Jan 9, 2023

Conversation

tbw777
Copy link
Contributor

@tbw777 tbw777 commented Jan 6, 2023 •
edited
Loading

replace() method is more fast then replaceAll() for non regex cases

@tbw777
Replaced a part of replaceAll() calls to replace()
f98e74d 
replace() method is more fast then replaceAll() for non regex cases
mbien
mbien approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me.

I remember skipping some less important modules in #3724, this is probably what remained.

@mbien mbien added this to the NB17 milestone Jan 9, 2023
@mbien mbien merged commit 0ecc672 into apache:master Jan 9, 2023
@tbw777 tbw777 deleted the replaceAll2 branch January 19, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

Assignees
No one assigned
Labels
Code cleanup
Projects
None yet
Milestone
NB17
Development

Successfully merging this pull request may close these issues.
2 participants
@tbw777 @mbien