-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of ANTLR4 Lexer Support #5206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Although, the last time i wrote a grammar was over a decade ago for the NetBeans GL and CL packs - so I am not going to be able to spot bugs just by looking at it :)
consider adding the test to the CI ide-modules-test
job:
https://github.com/apache/netbeans/blob/master/.github/workflows/main.yml#L341
since they won't start running automatically.
ide/lexer.antlr4/test/unit/src/org/netbeans/spi/lexer/antlr4/AntlrTokenSequenceTest.java
Show resolved
Hide resolved
I know this is already in, but one thing I thought about when looking at this was: are we prepared to make this API yet or should this be a purely internal package (i.e. Friend-only API without external users)? |
Well, this one does not introduce something big/groundbreaking. It's only 4 classes. Two of them: I could imagine that there could be bugs in the implementation, though I'd not expect the API change without keeping backward compatibility any time soon. (Unless ANTLR forces us to do so...) |
Hmm. Could make the |
* Initial implementation of ANTLR4 Lexer Support * More documentation on AbstractAntlrLexerBridge * Added lexer.antlr4 test to GH Workflows * Removed System.out.println from tests
Take number 2.
This is a bunch of collected knowledge, help to integrate ANTLR v4 based Lexers into NetBeans. This PR does not include the change of the existing ANTLR v4 based languages. If this one goes through, I'd provide separate PR-s for:
I could use this on my upcoming projects for: