Do not inherit "throws Exception" from Callable to compile on JDK8 #5191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5118, I have created a generic method that rethrows callable's (checked) exception using
sneaky throws
approach - but the code is not compilable on JDK8 because the JDK8 javac fails to infer types properly:One way is to typecast the lambda or augment the mehod call using explicit type parameters
<Object, Exception>
, but it seems that removingextends Callable
from theOCIOperation
interface does the same - and leaves caller code clean - and compiles on both JDK8 and JDK11 (JDK17)Please review asap - the code reached
master
branch and failed vscode testsuite ... was not discovered, since I didn't put enough labels on #5118 - sorry for the inconvenience.