Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETBEANS-4720 Support custom gradle test sourcesets #4721

Merged

Conversation

merscwog
Copy link
Contributor

@merscwog merscwog commented Oct 2, 2022

NetBeans 15 hardcodes the 'cleanTest' and 'test' tasks for all tests regardless of the test sourceset the code exists within. This should be 'clean[TestSourceSetName]' and '[testSourceSetName]' instead (which still works for the default test sourceset 'test'.


^Add meaningful description above

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

NetBeans 15 hardcodes the 'cleanTest' and 'test' tasks for all tests
regardless of the test sourceset the code exists within.  This should be
'clean[TestSourceSetName]' and '[testSourceSetName]' instead (which
still works for the default test sourceset 'test'.
@mbien mbien linked an issue Oct 3, 2022 that may be closed by this pull request
@mbien mbien added the Gradle [ci] enable "build tools" tests label Oct 3, 2022
@mbien mbien requested review from sdedic and lkishalmi and removed request for sdedic October 3, 2022 02:47
@lkishalmi lkishalmi added this to the NB16 milestone Oct 3, 2022
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!
Checked the git commit for valid name and email. that's Ok as well.
I'll wait for @sdedic to have a look as well, but will merge in a few days.

@lkishalmi lkishalmi merged commit 09990b1 into apache:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gradle [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom gradle test sourcesets not supported when running tests
3 participants