Enable Maven editor hints in LSP #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
enhancement
LSP
JaroslavTulach
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extension of #3793, this hint bridges Maven hints to LSP. The ErrorProvider runs explicitly parser task internals and report to LSP client.
Note that these changes would not be necessary if the LSP server would have been running the parser cycle ("kolecko") for document changes - but it does not -- see NETBEANS-6477.
I needed also to move Maven MIME type registration to lower layer module - but the base Maven module already contained registrations based on that MIME type - but did not define the resolver for it.