Hint/Inspection panel and dialog layout fixes #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
kind:bug
neilcsmith-net
added
the
do not merge
|
@mbien need to rebase on delivery if you want this in NB13 - picking up commits from master we don't want. |
|
In this case we don't want a rebase, but a cherry-pick. The difference is, that rebase will carry all commits from the base branch, that are not in the target branch, while cherry-picking only uses the referenced commits. |
- inspect dialog did not properly resize - refactor dialog had no separation between two rows
- description panel is now using all vertical space - required fixes to the customizer panels so that they only use the space they actually need - made the dialogs which use the hint panel a bit larger
|
@neilcsmith-net done @matthiasblaesing yeah that is correct. Although I did cherry pick to delivery, I still refer to it as "rebasing the two commits to delivery" myself - I probably shouldn't since it could be taken literally. |
|
@mbien thanks. @matthiasblaesing yes, rebasing was more a turn of phrase around changing the PR base branch. Mind you, still prefer using git rebase for this task myself, but don't mind how anyone wants to clean up their PR unless they need help with it. Now, as long as we don't get cherry-picking from upstream master I'm happy ... 😄 |
neilcsmith-net
removed
the
do not merge
mbien
added a commit
to mbien/netbeans
that referenced
this pull request
Nov 2, 2022
- analog to apache#3472, this fixes UI component resize behavior - description panel is now filling the space vertically like in the java version of this panel. Text is now wrapping properly. - the option panels had to be adjusted to prefer their minimum default size - minor language cleanup: diamonds, lambdas
mbien
added a commit
to mbien/netbeans
that referenced
this pull request
Nov 8, 2022
- analog to apache#3472, this fixes UI component resize behavior - updated all other HintsPanels to have the same initial divider pos - minor cleanup like lambdas and diamonds
Chris2011
pushed a commit
to Chris2011/netbeans
that referenced
this pull request
Dec 15, 2022
- analog to apache#3472, this fixes UI component resize behavior - description panel is now filling the space vertically like in the java version of this panel. Text is now wrapping properly. - the option panels had to be adjusted to prefer their minimum default size - minor language cleanup: diamonds, lambdas
Chris2011
pushed a commit
to Chris2011/netbeans
that referenced
this pull request
Dec 15, 2022
- analog to apache#3472, this fixes UI component resize behavior - updated all other HintsPanels to have the same initial divider pos - minor cleanup like lambdas and diamonds
pepness
pushed a commit
to pepness/incubator-netbeans
that referenced
this pull request
Jan 9, 2023
- analog to apache#3472, this fixes UI component resize behavior - description panel is now filling the space vertically like in the java version of this panel. Text is now wrapping properly. - the option panels had to be adjusted to prefer their minimum default size - minor language cleanup: diamonds, lambdas
pepness
pushed a commit
to pepness/incubator-netbeans
that referenced
this pull request
Jan 9, 2023
- analog to apache#3472, this fixes UI component resize behavior - updated all other HintsPanels to have the same initial divider pos - minor cleanup like lambdas and diamonds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source -> inspectdialog did not resize properlyrefactor -> inspect and refactordialog had no separation between row two and three (very similar dialog to the one above but uses a different layout manager :) )options -> editor -> hintsor from various configuration dialogs