jdk 20+ build compatibility: bump minimum compiler target to 1.8.

- use -Xlint:-options due to obsolete source/target warning and -Werror - fix some javac warnings which fail due to -Werror in SuiteSources.java - add JDK 20ea to test matrix
apache · Dec 20, 2022 · d61f8b8 · d61f8b8
1 parent a8edf3b
commit d61f8b8
Show file tree

Hide file tree

Showing 399 changed files with 408 additions and 414 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -91,7 +91,7 @@ jobs:
     timeout-minutes: 60
     strategy:
       matrix:
-        java: [ '11', '17', '19' ]
+        java: [ '11', '17', '20-ea' ]
       fail-fast: false
     steps:
 
@@ -115,7 +115,7 @@ jobs:
           restore-keys: ${{ runner.os }}-
 
       - name: Setup Gradle Daemon to run on JDK 11
-        if: ${{ matrix.java > 18 }}
+        if: ${{ matrix.java == '20-ea' }}
         run: |
           mkdir -p ~/.gradle
           #uses a preinstalled JDK 11 from the runner
@@ -159,7 +159,7 @@ jobs:
     timeout-minutes: 60
     strategy:
       matrix:
-        java: [ '8', '11', '17', '19' ]
+        java: [ '8', '11', '17', '20-ea' ]
       fail-fast: false
     steps:
 
@@ -170,7 +170,6 @@ jobs:
           distribution: ${{ env.default_java_distribution }}
 
       - name: Setup Xvfb
-        if: ${{ matrix.java != '20-ea' }}  # see #4299
         run: |
           echo "DISPLAY=:99.0" >> $GITHUB_ENV
           Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &

diff --git a/apisupport/apisupport.installer.maven/nbproject/project.properties b/apisupport/apisupport.installer.maven/nbproject/project.properties
@@ -15,5 +15,5 @@
 # specific language governing permissions and limitations
 # under the License.
 is.eager=true
-javac.source=1.6
+javac.source=1.8
 javac.compilerargs=-Xlint -Xlint:-serial
diff --git a/apisupport/apisupport.installer/nbproject/project.properties b/apisupport/apisupport.installer/nbproject/project.properties
@@ -14,6 +14,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-javac.source=1.6
+javac.source=1.8
 javac.compilerargs=-Xlint -Xlint:-serial
 nbm.module.author=Dmitry Lipin
diff --git a/apisupport/apisupport.kit/nbproject/project.properties b/apisupport/apisupport.kit/nbproject/project.properties
@@ -15,4 +15,4 @@
 # specific language governing permissions and limitations
 # under the License.
 javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.6
+javac.source=1.8
diff --git a/apisupport/apisupport.refactoring/nbproject/project.properties b/apisupport/apisupport.refactoring/nbproject/project.properties
@@ -16,5 +16,5 @@
 # under the License.
 
 is.eager=true
-javac.source=1.7
+javac.source=1.8
 requires.nb.javac=true
diff --git a/contrib/cordova.platforms.ios/nbproject/project.properties b/contrib/cordova.platforms.ios/nbproject/project.properties
@@ -14,7 +14,7 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-javac.source=1.7
+javac.source=1.8
 javac.compilerargs=-Xlint -Xlint:-serial
 release.external/ios-sim=bin/ios-sim
 release.external/libiDeviceNativeBinding.dylib=bin/libiDeviceNativeBinding.dylib

diff --git a/contrib/form.j2ee/nbproject/project.properties b/contrib/form.j2ee/nbproject/project.properties
@@ -16,6 +16,6 @@
 # under the License.
 
 is.eager=true
-javac.source=1.6
+javac.source=1.8
 spec.version.base=0.36.0
 requires.nb.javac=true
diff --git a/contrib/groovy.grails/nbproject/project.properties b/contrib/groovy.grails/nbproject/project.properties
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.6
+javac.source=1.8
 nbm.homepage=http://wiki.netbeans.org/groovy
 nbm.module.author=Martin Adamek, Petr Hejl, Matthias Schmidt
 

diff --git a/contrib/hibernateweb/nbproject/project.properties b/contrib/hibernateweb/nbproject/project.properties
@@ -18,6 +18,6 @@
 build.compiler.deprecation=false
 is.eager=true
 javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.6
+javac.source=1.8
 
 
diff --git a/contrib/j2ee.jboss4/nbproject/project.properties b/contrib/j2ee.jboss4/nbproject/project.properties
@@ -16,7 +16,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-javac.source=1.6
+javac.source=1.8
 #javac.compilerargs=-Xlint:unchecked
 
 

diff --git a/contrib/j2ee.jboss4/test/qa-functional/data/JBoss4EjbTest/nbproject/project.properties b/contrib/j2ee.jboss4/test/qa-functional/data/JBoss4EjbTest/nbproject/project.properties
@@ -19,7 +19,7 @@ jar.name=JBoss4EjbTest.jar
 javac.classpath=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.4
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/contrib/j2ee.jboss4/test/qa-functional/data/JBoss4WebTest/nbproject/project.properties b/contrib/j2ee.jboss4/test/qa-functional/data/JBoss4WebTest/nbproject/project.properties
@@ -27,7 +27,7 @@ javac.classpath=
 javac.compilerargs=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.4
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/...ib/j2ee.jboss4/test/qa-functional/data/TestDeployDebugWebApp/nbproject/project.properties b/...ib/j2ee.jboss4/test/qa-functional/data/TestDeployDebugWebApp/nbproject/project.properties
@@ -27,7 +27,7 @@ javac.classpath=
 javac.compilerargs=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.4
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/contrib/j2ee.weblogic9/nbproject/project.properties b/contrib/j2ee.weblogic9/nbproject/project.properties
@@ -17,7 +17,7 @@
 # under the License.
 #
 
-javac.source=1.6
+javac.source=1.8
 spec.version.base=1.45.0
 
 test.config.stableBTD.includes=**/*Test.class

diff --git a/contrib/libs.svnClientAdapter.svnkit/nbproject/project.properties b/contrib/libs.svnClientAdapter.svnkit/nbproject/project.properties
@@ -17,7 +17,7 @@
 
 
 is.eager=true
-javac.source=1.6
+javac.source=1.8
 release.external/svnClientAdapter-svnkit-1.10.12.jar=modules/ext/svnClientAdapter-svnkit.jar
 release.external/org.tmatesoft.svnkit_1.8.12.r10533_v20160129_0158.jar=modules/ext/svnkit.jar
 release.external/sqljet-1.1.10.jar=modules/ext/sqljet.jar

diff --git a/contrib/websvc.metro.model/nbproject/project.properties b/contrib/websvc.metro.model/nbproject/project.properties
@@ -18,7 +18,7 @@ auxiliary.org-netbeans-modules-editor-indent.CodeStyle.project.tab-size=8
 auxiliary.org-netbeans-modules-editor-indent.CodeStyle.project.text-limit-width=80
 auxiliary.org-netbeans-modules-editor-indent.CodeStyle.usedProfile=default
 is.eager=true
-javac.source=1.6
+javac.source=1.8
 javadoc.title=Configuration model for metro.xml config file
 javadoc.overview=${basedir}/overview.html
 javadoc.arch=${basedir}/../arch/arch-websvc-metro-model.xml

diff --git a/contrib/websvc.wsitconf/nbproject/project.properties b/contrib/websvc.wsitconf/nbproject/project.properties
@@ -16,7 +16,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-javac.source=1.6
+javac.source=1.8
 javadoc.title=Web Services Interoperability Technologies Configuration Module
 javadoc.overview=${basedir}/overview.html
 javadoc.arch=${basedir}/../arch/arch-websvc-wsitconf.xml

diff --git a/contrib/websvc.wsitmodelext/nbproject/project.properties b/contrib/websvc.wsitmodelext/nbproject/project.properties
@@ -16,7 +16,7 @@
 # specific language governing permissions and limitations
 # under the License.
 is.autoload=true
-javac.source=1.6
+javac.source=1.8
 javadoc.title=Web Services Interoperability Technologies WSDL Extensions Module
 javadoc.overview=${basedir}/overview.html
 javadoc.arch=${basedir}/../arch/arch-websvc-wsitmodelext.xml

diff --git a/cpplite/cpplite.kit/nbproject/project.properties b/cpplite/cpplite.kit/nbproject/project.properties
@@ -15,5 +15,5 @@
 # specific language governing permissions and limitations
 # under the License.
 
-javac.source=1.7
+javac.source=1.8
 javac.compilerargs=-Xlint -Xlint:-serial
diff --git a/enterprise/api.web.webmodule/nbproject/project.properties b/enterprise/api.web.webmodule/nbproject/project.properties
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-javac.source=1.6
+javac.source=1.8
 javac.compilerargs=-Xlint -Xlint:-serial
 
 is.autoload=true

diff --git a/enterprise/el.lexer/nbproject/project.properties b/enterprise/el.lexer/nbproject/project.properties
@@ -17,7 +17,7 @@
 
 is.autoload=true
 javac.compilerargs=-Xlint:unchecked
-javac.source=1.6
+javac.source=1.8
 #javadoc.arch=${basedir}/arch.xml
 #javadoc.apichanges=${basedir}/apichanges.xml
 javadoc.title=Expression Language Lexer API

diff --git a/...2ee.clientproject/test/unit/data/projects/ApplicationClient1/nbproject/project.properties b/...2ee.clientproject/test/unit/data/projects/ApplicationClient1/nbproject/project.properties
@@ -30,7 +30,7 @@ javac.classpath=\
 # Space-separated list of extra javac options
 javac.compilerargs=
 javac.deprecation=false
-javac.source=1.4
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ddloaders/test/unit/data/projects/webapp/nbproject/project.properties b/enterprise/j2ee.ddloaders/test/unit/data/projects/webapp/nbproject/project.properties
@@ -45,7 +45,7 @@ javac.classpath=
 javac.compilerargs=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.4
+javac.source=1.8
 javac.target=${default.javac.target}
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbcore/test/unit/data/ApplicationClient_1_4/nbproject/project.properties b/enterprise/j2ee.ejbcore/test/unit/data/ApplicationClient_1_4/nbproject/project.properties
@@ -26,7 +26,7 @@ javac.classpath=
 # Space-separated list of extra javac options
 javac.compilerargs=
 javac.deprecation=false
-javac.source=1.4
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbcore/test/unit/data/ApplicationClient_5_0/nbproject/project.properties b/enterprise/j2ee.ejbcore/test/unit/data/ApplicationClient_5_0/nbproject/project.properties
@@ -26,7 +26,7 @@ javac.classpath=
 # Space-separated list of extra javac options
 javac.compilerargs=
 javac.deprecation=false
-javac.source=1.5
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbcore/test/unit/data/EJBModule2_1_4/nbproject/project.properties b/enterprise/j2ee.ejbcore/test/unit/data/EJBModule2_1_4/nbproject/project.properties
@@ -19,7 +19,7 @@ jar.name=EJBModule2_1_4.jar
 javac.classpath=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.4
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbcore/test/unit/data/EJBModule_1_4/nbproject/project.properties b/enterprise/j2ee.ejbcore/test/unit/data/EJBModule_1_4/nbproject/project.properties
@@ -19,7 +19,7 @@ jar.name=EJBModule_1_4.jar
 javac.classpath=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.4
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbcore/test/unit/data/EJBModule_5_0/nbproject/project.properties b/enterprise/j2ee.ejbcore/test/unit/data/EJBModule_5_0/nbproject/project.properties
@@ -19,7 +19,7 @@ jar.name=EJBModule_5_0.jar
 javac.classpath=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.5
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbcore/test/unit/data/EJBModule_6_0/nbproject/project.properties b/enterprise/j2ee.ejbcore/test/unit/data/EJBModule_6_0/nbproject/project.properties
@@ -19,7 +19,7 @@ jar.name=EJBModule_6_0.jar
 javac.classpath=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.5
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbcore/test/unit/data/EJBModule_7_0/nbproject/project.properties b/enterprise/j2ee.ejbcore/test/unit/data/EJBModule_7_0/nbproject/project.properties
@@ -19,7 +19,7 @@ jar.name=EJBModule_7_0.jar
 javac.classpath=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.5
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/...rprise/j2ee.ejbcore/test/unit/data/EnterpriseApplication_1_4/nbproject/project.properties b/...rprise/j2ee.ejbcore/test/unit/data/EnterpriseApplication_1_4/nbproject/project.properties
@@ -20,7 +20,7 @@ jar.content.additional=\
 jar.name=EnterpriseApplication_1_4.ear
 javac.debug=true
 javac.deprecation=false
-javac.source=1.4
+javac.source=1.8
 javac.target=1.8
 meta.inf=src/conf
 no.dependencies=false

diff --git a/...rprise/j2ee.ejbcore/test/unit/data/EnterpriseApplication_5_0/nbproject/project.properties b/...rprise/j2ee.ejbcore/test/unit/data/EnterpriseApplication_5_0/nbproject/project.properties
@@ -20,7 +20,7 @@ jar.content.additional=\
 jar.name=EnterpriseApplication_5_0.ear
 javac.debug=true
 javac.deprecation=false
-javac.source=1.5
+javac.source=1.8
 javac.target=1.8
 meta.inf=src/conf
 no.dependencies=false

diff --git a/enterprise/j2ee.ejbcore/test/unit/data/WebApplication_1_4/nbproject/project.properties b/enterprise/j2ee.ejbcore/test/unit/data/WebApplication_1_4/nbproject/project.properties
@@ -27,7 +27,7 @@ javac.classpath=
 javac.compilerargs=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.4
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbcore/test/unit/data/WebApplication_5_0/nbproject/project.properties b/enterprise/j2ee.ejbcore/test/unit/data/WebApplication_5_0/nbproject/project.properties
@@ -27,7 +27,7 @@ javac.classpath=
 javac.compilerargs=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.5
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/.../j2ee.ejbjarproject/test/unit/data/projects/BrokenEJBModule1/nbproject/project.properties b/.../j2ee.ejbjarproject/test/unit/data/projects/BrokenEJBModule1/nbproject/project.properties
@@ -19,7 +19,7 @@ jar.name=BrokenEJBModule1.jar
 javac.classpath=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.4
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/...rprise/j2ee.ejbjarproject/test/unit/data/projects/EJBModule1/nbproject/project.properties b/...rprise/j2ee.ejbjarproject/test/unit/data/projects/EJBModule1/nbproject/project.properties
@@ -22,7 +22,7 @@ jar.name=EJBModule1.jar
 javac.classpath=${file.reference.jar0.jar}
 javac.debug=true
 javac.deprecation=false
-javac.source=1.4
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/...ise/j2ee.ejbjarproject/test/unit/data/projects/EJBModule_6_0/nbproject/project.properties b/...ise/j2ee.ejbjarproject/test/unit/data/projects/EJBModule_6_0/nbproject/project.properties
@@ -19,7 +19,7 @@ jar.name=EJBModule_6_0.jar
 javac.classpath=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.5
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbverification/test/unit/data/EJBModule_5_0/nbproject/project.properties b/enterprise/j2ee.ejbverification/test/unit/data/EJBModule_5_0/nbproject/project.properties
@@ -19,7 +19,7 @@ jar.name=EJBModule_5_0.jar
 javac.classpath=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.5
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbverification/test/unit/data/EJBModule_6_0/nbproject/project.properties b/enterprise/j2ee.ejbverification/test/unit/data/EJBModule_6_0/nbproject/project.properties
@@ -19,7 +19,7 @@ jar.name=EJBModule_6_0.jar
 javac.classpath=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.5
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbverification/test/unit/data/EJBModule_7_0/nbproject/project.properties b/enterprise/j2ee.ejbverification/test/unit/data/EJBModule_7_0/nbproject/project.properties
@@ -19,7 +19,7 @@ jar.name=EJBModule_7_0.jar
 javac.classpath=
 javac.debug=true
 javac.deprecation=false
-javac.source=1.5
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbverification/test/unit/data/WebModule_6_0/nbproject/project.properties b/enterprise/j2ee.ejbverification/test/unit/data/WebModule_6_0/nbproject/project.properties
@@ -46,7 +46,7 @@ javac.debug=true
 javac.deprecation=false
 javac.processorpath=\
     ${javac.classpath}
-javac.source=1.7
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\

diff --git a/enterprise/j2ee.ejbverification/test/unit/data/WebModule_7_0/nbproject/project.properties b/enterprise/j2ee.ejbverification/test/unit/data/WebModule_7_0/nbproject/project.properties
@@ -46,7 +46,7 @@ javac.debug=true
 javac.deprecation=false
 javac.processorpath=\
     ${javac.classpath}
-javac.source=1.7
+javac.source=1.8
 javac.target=1.8
 javac.test.classpath=\
     ${javac.classpath}:\