This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-859] Add a clang-tidy stage to CI #12282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This integrates clang-tidy into our CI system. Clang-tidy is a modern c++ linting and static-analysis tool that can find issues in our native codebase. It can also be used to modernize the codebase, suggesting improvements to adopt features that have been added to the C++11 standard.
This initial integration marks many rules as warnings and only targets cpu builds for our core native codebase. I'd like to try and introduce this as a minimum useful change. As we fix warnings we can move rules to errors in the configuration to protect against regressions.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.