[MNG-8602] Fix BOM consumer pom #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstamas
reviewed
Mar 3, 2025
| .preserveModelVersion(false) | ||
| .root(false) | ||
| .parent(null) | ||
| // .dependencyManagement(dependencyManagement.withDependencies(dependencies)) |
There was a problem hiding this comment.
why was this added at all? Was it envisioned that BOM may contain only reactor deps? As then we may want to enforce that
There was a problem hiding this comment.
There was a problem hiding this comment.
The problem is that the consumer POM for the BOM was originally created like a POM, i.e. from the raw model, and it was missing some versions for managed dependencies. The fix was overwriting the dependency version with the model version. This is now correctly implemented by using the effective model instead of the raw model.
cstamas
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: MNG-8602