[MNG-8591] Fix default value for plugin resolution (which has always been null) #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
changed the title
cstamas
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: MNG-8591
Fixes apache/maven-clean-plugin#104
The cause is that Maven 3 has a hand-written parser for the plugin.xml. So while the schema was specifying a default value of
runtime, this was not the one actually used, as the code was only setting the value when something was specified in the xml. Maven 4 now uses a modello generated reader which actually uses the default value which leads to the problem reported above. Removing the default value from the schema will fix the problem and align the schema with the actual behavior in Maven 3.