try with resources #5
Conversation
| @@ -300,8 +293,6 @@ private void populateFile( File file ) throws IOException | |||
| try ( FileOutputStream outputStream = new FileOutputStream( file ) ) | |||
| { | |||
| outputStream.write( data.getBytes() ); | |||
| outputStream.flush(); | |||
There was a problem hiding this comment.
Don't think the .flush() is guaranteed by try-with-resources... but perhaps by not wrapping FOS in a BufferedOutputStream then that's not a problem?
There was a problem hiding this comment.
I think @roxspring is right about FOS not wrapped in BOS not being problem for flushing or not. But I'm not sure that close also flushes. There is flush called in FOS.finalize but close inherited from OutputStream is no-op (immaterial), as FOS.close doesn't seem to call flush neither.
On the other hand close of BufferedOutputStream flushes indeed.
There was a problem hiding this comment.
Calling flush just before close is generally useless cause close ensures all data have been written.
That said we are speaking of a FileOutputStream where flush() is a noop so it is even safer to drop.
@roxspring