Improve assert usages (#109)

* Improve asserts
apache · Feb 26, 2025 · adc360a · adc360a
1 parent 59f0806
commit adc360a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/test/java/org/apache/maven/report/projectinfo/DependenciesReportTest.java b/src/test/java/org/apache/maven/report/projectinfo/DependenciesReportTest.java
@@ -66,9 +66,9 @@ public void testReport() throws Exception {
         // Test the tables
         WebTable[] webTables = response.getTables();
         // One table with listing and one table per artifact popup
-        assertEquals(webTables.length, 3);
+        assertEquals(3, webTables.length);
 
-        assertEquals(webTables[0].getColumnCount(), 5);
+        assertEquals(5, webTables[0].getColumnCount());
         assertEquals(
                 webTables[0].getRowCount(),
                 1 + getTestMavenProject().getDependencies().size());

diff --git a/src/test/java/org/apache/maven/report/projectinfo/DependencyManagementReportTest.java b/src/test/java/org/apache/maven/report/projectinfo/DependencyManagementReportTest.java
@@ -67,9 +67,9 @@ public void testReport() throws Exception {
 
         // Test the tables
         WebTable[] webTables = response.getTables();
-        assertEquals(webTables.length, 1);
+        assertEquals(1, webTables.length);
 
-        assertEquals(webTables[0].getColumnCount(), 5);
+        assertEquals(5, webTables[0].getColumnCount());
         assertEquals(
                 webTables[0].getRowCount(),
                 1

diff --git a/src/test/java/org/apache/maven/report/projectinfo/MailingListsReportTest.java b/src/test/java/org/apache/maven/report/projectinfo/MailingListsReportTest.java
@@ -79,7 +79,7 @@ public void testReport() throws Exception {
         assertEquals("MAILTO:test-subscribe2@maven.apache.org", subscribeLinks[1].getAttribute("href"));
         String unsubscribe = getString("report.mailing-lists.column.unsubscribe");
         WebLink[] unsubscribeLinks = response.getMatchingLinks(WebLink.MATCH_CONTAINED_TEXT, unsubscribe);
-        assertTrue(unsubscribeLinks.length == 1);
+        assertEquals(1, unsubscribeLinks.length);
         assertEquals("https://example.com/unsubscribe", unsubscribeLinks[0].getAttribute("href"));
     }