-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning #58
Conversation
Those are not Maven Core components, they are merely in wrong groupId. Extended ITs to use maven-jxr as well.
Can we really do it outside maven plugin api subgraph? Dont think so today :( |
WDYM? |
@michael-o except maven-plugin-api which is intentionally exposed rest of maven sub-artifacts are random and either internals or public API so none can be assumed being provided so this sounds like a lot of false positive to me. What about not warning for all but the plugin api and maybe maven-core? |
@rmannibucau Which other false positives do you foresee? I am actually thankful for the warnings for "maven-artifact" and "maven-model" (those are API IMHO since forever) |
Maven comes OOTB with:
From there, maven-plugin-api and maven-model are public, part (part is important there) of maven-core is too and rest is fully undefined or private as of today - not 100% sure for artifact since it changed a bit but agree it used to leak so I assume it is okish to include it. This is only for built-in maven artifacts and not maven ecosystem so guess we can only whitelist the 2-3 dependencies and not include all and exclude a few in terms of impl. |
maven-plugin-plugin/src/it/mplugin-370-maven-deps-scope-bad/pom.xml
Outdated
Show resolved
Hide resolved
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
Outdated
Show resolved
Hide resolved
Make it configurable and skippable.
Those are not Maven Core components, they are merely in
wrong groupId. Extended ITs to use maven-jxr as well.