Introduce IndexSearcher#searchLeaf(LeafReaderContext, Weight, Collector) method #13603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or) method There's a couple of places in the codebase where we extend IndexSearcher to customize per leaf behaviour, and in order to do that, we need to override the entire search method that loops through the leaves. A good example is ScorerIndexSearcher. Adding a searchLeaf method that provides the per leaf behaviour makes those cases a little easier to deal with. Also, it paves the road for apache#13542 where we will want to replace search(List<LeafReaderContext>, Weight, Collector) with something along the lines of search(LeafReaderContextPartition[], Weight, Collector).
javanna
commented
Jul 23, 2024
| } | ||
| // Note: this is called if collection ran successfully, including the above special cases of | ||
| // CollectionTerminatedException and TimeExceededException, but no other exception. | ||
| leafCollector.finish(); |
There was a problem hiding this comment.
The diff is misleading: this is a pure cut and paste of the code from within the existing loop, to the new method that's called for every entry.
gsmiller
approved these changes
Jul 29, 2024
|
Thanks a lot for your review @gsmiller , much appreciated, and for the reminder around the CHANGES entry. Would you like to review the wording perhaps? Otherwise, this should be good to go. My thinking is that it can be backported to branch_9x as well. |
|
Thank you again for the review @gsmiller ! |
javanna
added a commit
to javanna/lucene
that referenced
this pull request
Jul 30, 2024
…or) method (apache#13603) There's a couple of places in the codebase where we extend `IndexSearcher` to customize per leaf behaviour, and in order to do that, we need to override the entire search method that loops through the leaves. A good example is `ScorerIndexSearcher`. Adding a `searchLeaf` method that provides the per leaf behaviour makes those cases a little easier to deal with.
|
@javanna yeah no problem. All looks good to me. +1 to backporting to 9.12. Thanks! |
javanna
added a commit
that referenced
this pull request
Jul 30, 2024
…or) method (#13603) There's a couple of places in the codebase where we extend `IndexSearcher` to customize per leaf behaviour, and in order to do that, we need to override the entire search method that loops through the leaves. A good example is `ScorerIndexSearcher`. Adding a `searchLeaf` method that provides the per leaf behaviour makes those cases a little easier to deal with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a couple of places in the codebase where we extend IndexSearcher to customize per leaf behaviour, and in order to do that, we need to override the entire search method that loops through the leaves. A good example is ScorerIndexSearcher.
Adding a searchLeaf method that provides the per leaf behaviour makes those cases a little easier to deal with. Also, it paves the road for #13542 where we will want to replace
search(List<LeafReaderContext>, Weight, Collector)with something along the lines ofsearch(LeafReaderContextPartition[], Weight, Collector). Such switch will be made easier by no longer having extensions ofIndexSearcherthat provide per-leaf behaviour by overriding the former method.