-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IntervalsSource for range and regexp queries #13562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have convenient functions for contructing IntervalsSource for wildcard and fuzzy functions. This adds functions for regexp and range as well.
romseygeek
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of javadoc nits, but LGTM otherwise
lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java
Outdated
Show resolved
Hide resolved
lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java
Outdated
Show resolved
Hide resolved
lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java
Outdated
Show resolved
Hide resolved
dweiss
approved these changes
Jul 12, 2024
@romseygeek @dweiss Thank you for the review. |
mayya-sharipova
added a commit
to mayya-sharipova/lucene
that referenced
this pull request
Jul 14, 2024
We already have convenient functions for contructing IntervalsSource for wildcard and fuzzy functions. This adds functions for regexp and range as well.
mayya-sharipova
added a commit
that referenced
this pull request
Jul 15, 2024
We already have convenient functions for contructing IntervalsSource for wildcard and fuzzy functions. This adds functions for regexp and range as well. Backport for PR #13562
mayya-sharipova
added a commit
to mayya-sharipova/lucene
that referenced
this pull request
Oct 4, 2024
Currently IntervalsSource.range function closed intervals. This will allow open-ended ranges Relates to apache#13562
mayya-sharipova
added a commit
that referenced
this pull request
Oct 7, 2024
Currently IntervalsSource.range function closed intervals. This will allow open-ended ranges Relates to #13562
mayya-sharipova
added a commit
to mayya-sharipova/lucene
that referenced
this pull request
Oct 8, 2024
Currently IntervalsSource.range function closed intervals. This will allow open-ended ranges Relates to apache#13562
mayya-sharipova
added a commit
that referenced
this pull request
Oct 9, 2024
Currently IntervalsSource.range function closed intervals. This will allow open-ended ranges Relates to #13562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have convenient functions for contructing IntervalsSource for wildcard and fuzzy functions. This adds functions for regexp and range as well.