Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Support GetPrimaryKeys for Trino Fe #4320

Closed
3 of 4 tasks
Tracked by #3901
yikf opened this issue Feb 14, 2023 · 0 comments
Closed
3 of 4 tasks
Tracked by #3901

[Subtask] Support GetPrimaryKeys for Trino Fe #4320

yikf opened this issue Feb 14, 2023 · 0 comments
Labels
kind:subtask a subtask of umbrella ticket

Comments

@yikf
Copy link
Contributor

yikf commented Feb 14, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the subtask

Support GetPrimaryKeys for Trino Fe

Parent issue

#3901

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@yikf yikf added the kind:subtask a subtask of umbrella ticket label Feb 14, 2023
This was referenced Feb 14, 2023
Closed
Closed
ulysses-you pushed a commit that referenced this issue Feb 14, 2023
@yikf @ulysses-you
[KYUUBI #4320] Support GetPrimaryKeys for Trino Fe
6224583 
### _Why are the changes needed?_

Support GetPrimaryKeys for Trino Fe, close #4320

### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4321 from Yikf/primaryKeys.

Closes #4320

3690a2c [Yikf] Support GetPrimaryKeys for Trino Fe

Authored-by: Yikf <yikaifei@apache.org>
Signed-off-by: ulyssesyou <ulyssesyou@apache.org>
(cherry picked from commit 02deaf4)
Signed-off-by: ulyssesyou <ulyssesyou@apache.org>
yanghua pushed a commit to awesome-kyuubi/kyuubi that referenced this issue Apr 25, 2023
@yikf @yanghua
[KYUUBI apache#4320] Support GetPrimaryKeys for Trino Fe
26aa92a 
### _Why are the changes needed?_

Support GetPrimaryKeys for Trino Fe, close apache#4320

### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes apache#4321 from Yikf/primaryKeys.

Closes apache#4320

3690a2c [Yikf] Support GetPrimaryKeys for Trino Fe

Authored-by: Yikf <yikaifei@apache.org>
Signed-off-by: ulyssesyou <ulyssesyou@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:subtask a subtask of umbrella ticket
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #4320] Support GetPrimaryKeys for Trino Fe
1 participant
@yikf