Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-4949][Manager] Support to extend different types of Sort protocol #4954

Merged
merged 1 commit into from
Jul 11, 2022
Merged

[INLONG-4949][Manager] Support to extend different types of Sort protocol #4954

merged 1 commit into from
Jul 11, 2022

Conversation

healchow
Copy link
Member

@healchow healchow commented Jul 11, 2022 •
edited
Loading

Prepare a Pull Request

Motivation

Support to extend different types of Sort protocol.

Modifications

  1. Get the SortConfigOperator via the SortConfigOperatorFactory.
  2. Execute the build Sort config logic by the specified SortConfigOperator, such as SortConfig4NormalGroupOperator.
  3. Change the CreateSortConfigListener to SortConfigListener.
  4. Change the CreateStreamSortConfigListener to StreamSortConfigListener.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

@healchow healchow self-assigned this Jul 11, 2022
vernedeng
vernedeng approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@vernedeng vernedeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit b65788b into apache:master Jul 11, 2022
@healchow healchow deleted the INLONG-healchow branch July 12, 2022 01:55
@healchow healchow mentioned this pull request Jul 13, 2022
Closed
3 tasks
bruceneenhl pushed a commit to bruceneenhl/inlong that referenced this pull request Aug 12, 2022
@healchow @bruceneenhl
[INLONG-4949][Manager] Support to extend different types of Sort prot…
e069c10 
…ocol (apache#4954)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woofyzhao woofyzhao woofyzhao approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

@vernedeng vernedeng vernedeng approved these changes

Assignees

@healchow healchow

Labels
component/manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Manager] Support to extend different types of Sort protocol
4 participants
@healchow @woofyzhao @dockerzhang @vernedeng